clintropolis commented on code in PR #13803:
URL: https://github.com/apache/druid/pull/13803#discussion_r1141642926
##########
processing/src/test/resources/nested-array-test-data.json:
##########
@@ -0,0 +1,14 @@
+{"timestamp": "2023-01-01T00:00:00", "arrayString": ["a", "b"],
"arrayStringNulls": ["a", "b"], "arrayLong":[1, 2, 3],
"arrayLongNulls":[1, null,3], "arrayDouble":[1.1, 2.2, 3.3],
"arrayDoubleNulls":[1.1, 2.2, null], "arrayVariant":["a", 1, 2.2],
"arrayObject":[{"x": 1},{"x":2}]}
+{"timestamp": "2023-01-01T00:00:00", "arrayString": ["a", "b", "c"],
"arrayStringNulls": [null, "b"], "arrayLong":[2, 3],
"arrayDouble":[3.3, 4.4, 5.5], "arrayDoubleNulls":[999,
null, 5.5], "arrayVariant":[null, null, 2.2], "arrayObject":[{"x": 3},{"x":4}]}
+{"timestamp": "2023-01-01T00:00:00", "arrayString": ["b", "c"],
"arrayStringNulls": ["d", null, "b"], "arrayLong":[1, 2, 3, 4],
"arrayLongNulls":[1, 2, 3], "arrayDouble":[1.1, 3.3],
"arrayDoubleNulls":[null, 2.2, null], "arrayVariant":[1, null, 1],
"arrayObject":[null,{"x":2}]}
+{"timestamp": "2023-01-01T00:00:00", "arrayString": ["d", "e"],
"arrayStringNulls": ["b", "b"], "arrayLong":[1, 4],
"arrayLongNulls":[1], "arrayDouble":[2.2, 3.3, 4.0],
"arrayVariant":["a", "b", "c"], "arrayObject":[{"x":
null},{"x":2}]}
+{"timestamp": "2023-01-01T00:00:00", "arrayString": null,
"arrayLong":[1, 2, 3], "arrayLongNulls":null,
"arrayDouble":[1.1, 2.2, 3.3], "arrayDoubleNulls":null,
"arrayObject":[{"x": 1000},{"y":2000}]}
+{"timestamp": "2023-01-01T00:00:00", "arrayString": ["a", "b"],
"arrayStringNulls": null,
"arrayLongNulls":[null, 2, 9], "arrayDouble":null,
"arrayDoubleNulls":[999, 5.5, null], "arrayVariant":["a", 1, 2.2],
"arrayObject":[{"a": 1},{"b":2}]}
+{"timestamp": "2023-01-01T00:00:00",
"arrayStringNulls": ["a", "b"], "arrayLong":null,
"arrayLongNulls":[2, 3],
"arrayDoubleNulls":[null, 1.1], "arrayVariant":null,
"arrayObject":[{"x": 1},{"x":2}]}
+{"timestamp": "2023-01-02T00:00:00", "arrayString": ["a", "b"],
"arrayStringNulls": ["a", "b"], "arrayLong":[1, 2, 3],
"arrayLongNulls":[1, null,3], "arrayDouble":[1.1, 2.2, 3.3],
"arrayDoubleNulls":[1.1, 2.2, null], "arrayVariant":["a", 1, 2.2],
"arrayObject":[{"x": 1},{"x":2}]}
+{"timestamp": "2023-01-02T00:00:00", "arrayString": ["a", "b", "c"],
"arrayStringNulls": [null, "b"], "arrayLong":[2, 3],
"arrayDouble":[3.3, 4.4, 5.5], "arrayDoubleNulls":[999,
null, 5.5], "arrayVariant":[null, null, 2.2], "arrayObject":[{"x": 3},{"x":4}]}
+{"timestamp": "2023-01-02T00:00:00", "arrayString": ["b", "c"],
"arrayStringNulls": ["d", null, "b"], "arrayLong":[1, 2, 3, 4],
"arrayLongNulls":[1, 2, 3], "arrayDouble":[1.1, 3.3],
"arrayDoubleNulls":[null, 2.2, null], "arrayVariant":[1, null, 1],
"arrayObject":[null,{"x":2}]}
+{"timestamp": "2023-01-02T00:00:00", "arrayString": ["d", "e"],
"arrayStringNulls": ["b", "b"], "arrayLong":[1, 4],
"arrayLongNulls":[1], "arrayDouble":[2.2, 3.3, 4.0],
"arrayVariant":["a", "b", "c"], "arrayObject":[{"x":
null},{"x":2}]}
+{"timestamp": "2023-01-02T00:00:00", "arrayString": null,
"arrayLong":[1, 2, 3], "arrayLongNulls":null,
"arrayDouble":[1.1, 2.2, 3.3], "arrayDoubleNulls":null,
"arrayObject":[{"x": 1000},{"y":2000}]}
+{"timestamp": "2023-01-02T00:00:00", "arrayString": ["a", "b"],
"arrayStringNulls": null,
"arrayLongNulls":[null, 2, 9], "arrayDouble":null,
"arrayDoubleNulls":[999, 5.5, null], "arrayVariant":["a", 1, 2.2],
"arrayObject":[{"a": 1},{"b":2}]}
+{"timestamp": "2023-01-02T00:00:00",
"arrayStringNulls": ["a", "b"], "arrayLong":null,
"arrayLongNulls":[2, 3],
"arrayDoubleNulls":[null, 1.1], "arrayVariant":null,
"arrayObject":[{"x": 1},{"x":2}]}
Review Comment:
i'll add some tests for this, but assuming something like
ARRAY<ARRAY<STRING>> there would be an array column for each outer array element
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
