clintropolis commented on code in PR #13803: URL: https://github.com/apache/druid/pull/13803#discussion_r1141643257
########## processing/src/main/java/org/apache/druid/segment/nested/GlobalDimensionDictionary.java: ########## @@ -42,45 +47,107 @@ private final ComparatorDimensionDictionary<String> stringDictionary; private final ComparatorDimensionDictionary<Long> longDictionary; private final ComparatorDimensionDictionary<Double> doubleDictionary; + private final Set<Object[]> stringArrays; + private final Set<Object[]> longArrays; + private final Set<Object[]> doubleArrays; Review Comment: oh maybe this isn't used for merging segments... let me get back to you on this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
