mindreader commented on PR #13804:
URL: https://github.com/apache/druid/pull/13804#issuecomment-1478819088
Or let me know if I misunderstood you.
> > Do you also need to make this change?
> > ```diff
> > ---
a/extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java
> > +++
b/extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java
> > @@ -180,7 +180,7 @@ public class KubernetesTaskRunner implements
TaskLogStreamer, TaskRunner
> > completedPhase = monitorJob(peonPod, k8sTaskId);
> > } else {
> > Job job = existingJob.get();
> > - if (job.getStatus().getActive() == null) {
> > + if (job.getStatus() != null &&
job.getStatus().getActive() == null && (job.getStatus().getFailed() != null ||
job.getStatus().getSucceeded() !=null)) {
> > if (job.getStatus().getSucceeded() != null) {
> > completedPhase = new JobResponse(job,
PeonPhase.SUCCEEDED);
> > } else {
> > ```
>
> I believe that is the crux of the change. I explain why here: [#13804
(comment)](https://github.com/apache/druid/pull/13804#discussion_r1112268989)
Or let me know if I misunderstood you.
Sorry I wasn't clear. There are two spots in the code that have that same
success / failure logic, I only see one in this pr, after the job is monitored.
But I also see one before the job is monitored just after it is spawned in
KubernetesTaskRunner. If the logic is not necessary at that point, please feel
free to ignore me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
