churromorales commented on PR #13804:
URL: https://github.com/apache/druid/pull/13804#issuecomment-1478413747
> Do you also need to make this change?
>
> ```diff
> ---
a/extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java
> +++
b/extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java
> @@ -180,7 +180,7 @@ public class KubernetesTaskRunner implements
TaskLogStreamer, TaskRunner
> completedPhase = monitorJob(peonPod, k8sTaskId);
> } else {
> Job job = existingJob.get();
> - if (job.getStatus().getActive() == null) {
> + if (job.getStatus() != null &&
job.getStatus().getActive() == null && (job.getStatus().getFailed() != null ||
job.getStatus().getSucceeded() !=null)) {
> if (job.getStatus().getSucceeded() != null) {
> completedPhase = new JobResponse(job,
PeonPhase.SUCCEEDED);
> } else {
> ```
I believe that is the crux of the change. I explain why here:
https://github.com/apache/druid/pull/13804#discussion_r1112268989 Or let me
know if I misunderstood you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
