TSFenwick commented on code in PR #14131:
URL: https://github.com/apache/druid/pull/14131#discussion_r1178624962
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -129,8 +129,12 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
// Kill segments
toolbox.getTaskActionClient().submit(new SegmentNukeAction(new
HashSet<>(unusedSegments)));
- for (DataSegment segment : unusedSegments) {
- toolbox.getDataSegmentKiller().kill(segment);
+ if (getContextValue("batchDelete", false)) {
Review Comment:
Ah i was thinking the otherway around. have it be opt in at first, then opt
out. Just to make it be for the more safety conscious users to have a chance to
migrate to it. Never got around to imagining of removing it entirely. Im just
hung up the whole feature flag and how no other extension can take advantage of
it. So it's more of a best effort feature flag.
I would need to look into auto-kill and how that works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
