gianm commented on code in PR #14131:
URL: https://github.com/apache/druid/pull/14131#discussion_r1180577040
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -129,8 +129,12 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
// Kill segments
toolbox.getTaskActionClient().submit(new SegmentNukeAction(new
HashSet<>(unusedSegments)));
- for (DataSegment segment : unusedSegments) {
- toolbox.getDataSegmentKiller().kill(segment);
+ if (getContextValue("batchDelete", false)) {
Review Comment:
If we decide to go the "not require new APIs" route — which IMO is best —
then we should have a note in the interface that says that the multi-arg form
of `kill` must not require additional permissions on the deep storage beyond
what the single-arg form of `kill` requires. Otherwise, when a multi-arg impl
is contributed for another deep storage, it could break people in production
that don't have the right set of permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
