gianm commented on code in PR #14131:
URL: https://github.com/apache/druid/pull/14131#discussion_r1180574899
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -129,8 +129,12 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
// Kill segments
toolbox.getTaskActionClient().submit(new SegmentNukeAction(new
HashSet<>(unusedSegments)));
- for (DataSegment segment : unusedSegments) {
- toolbox.getDataSegmentKiller().kill(segment);
+ if (getContextValue("batchDelete", false)) {
Review Comment:
As to testing: one thing to think about is whether this uses any new S3 APIs
and therefore may require new IAM permissions. If it would require new IAM
permissions then we definitely need a feature flag and we need to call it out
in the docs and release notes. Or, better, adjust the design to not use new
APIs and not need new IAM permissions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
