kfaraz opened a new pull request, #14537:
URL: https://github.com/apache/druid/pull/14537
All duties on the Coordinator run on the same single-threaded executor
including historical management duties (segment loading and balancing) and
auto-compaction.
If auto-compaction gets stuck for some reason (such as slowness while
submitting tasks), it can block up the whole coordination flow causing delayed
segment handoffs and ingestion failures.
This PR attempts to remedy this situation by not blocking coordinator while
submitting compaction tasks by using the async `OverlordClient` instead of
`IndexingServiceClient`.
### Changes
- Use `OverlordClient` in `CompactSegments`
- All methods except submission of task still happen synchronously by using
`future.get()`.
- Fix up tests
### Alternate approach/Further improvement
- The coordinator duties can be moved to a completely separate executor but
that would require some validation to ensure that there are no race conditions
between historical management duties and coordinator duties (most likely, there
shouldn't be)
#### Release note
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
