imply-cheddar commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1263225696
##########
extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchBaseSqlAggregator.java:
##########
@@ -193,7 +193,8 @@ public Aggregation toDruidAggregation(
tgtHllType,
stringEncoding,
finalizeSketch ||
SketchQueryContext.isFinalizeOuterSketches(plannerContext),
- ROUND
+ ROUND,
+ false
Review Comment:
Do we have clear documentation on what type a column is expected to be when,
e.g., it was ingested as a long, then ingested as a String and then an ARRAY
and then back to a String? I'm a bit concerned with relying on the expected
type from the SQL schema as it's not guaranteed to accurately reflect what is
actually in the data. I think it's better to have the query itself define what
it wants to do and then use the information from the Sql schema as hints to
maybe specialize that (but the behavior defined by the actual written query
always wins).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
