imply-cheddar commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1261934223
##########
processing/src/main/java/org/apache/druid/query/filter/DruidPredicateFactory.java:
##########
@@ -33,6 +38,11 @@ public interface DruidPredicateFactory
DruidDoublePredicate makeDoublePredicate();
+ default Predicate<Object[]> makeArrayPredicate(@Nullable
TypeSignature<ValueType> inputType)
+ {
+ throw new UOE("Predicate does not support ARRAY types");
Review Comment:
Ah, `DruidException` has a `prependAndBuild()` method which takes the
current DruidException and just prepends values to it. The intent being that
it can be used to add extra context from higher levels in the code.
So, another option for that is to throw a `DruidException` here, catch it in
whatever code might expect to see it and do the `prependAndBuild()` to throw
with the added message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
