clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1264026555
##########
processing/src/test/resources/nested-all-types-test-data.json:
##########
@@ -1,7 +1,7 @@
{"timestamp": "2023-01-01T00:00:00", "str":"a", "long":1, "double":1.0,
"bool": true, "variant": 1, "variantEmptyObj":1,
"variantEmtpyArray":1, "obj":{"a": 100, "b": {"x": "a", "y": 1.1, "z": [1, 2,
3, 4]}}, "complexObj":{"x": 1234, "y": [{"l": ["a", "b", "c"], "m": "a",
"n": 1},{"l": ["a", "b", "c"], "m": "a", "n": 1}], "z": {"a": [1.1, 2.2, 3.3],
"b": true}}, "arrayString": ["a", "b"], "arrayStringNulls": ["a",
"b"], "arrayLong":[1, 2, 3], "arrayLongNulls":[1, null,3],
"arrayDouble":[1.1, 2.2, 3.3], "arrayDoubleNulls":[1.1, 2.2, null],
"arrayVariant":["a", 1, 2.2], "arrayBool":[true, false, true],
"arrayNestedLong":[[1, 2, null], [3, 4]], "arrayObject":[{"x":
1},{"x":2}], "null": null, "cstr": "hello", "clong": 1234, "cdouble":
1.234, "cObj":{"x": 1, "y": "hello", "z": {"a": 1.1, "b": 1234, "c": ["a", "b",
"c"]}}, "cstringArray": ["a", "b", "c"], "cLongArray": [1, 2, 3],
"cDoubleArray": [1.1, 2.2, 3.3], "cEmptyArray":[]
, "cEmptyObj":{}, "cNullArray": [null, null], "cEmptyObjectArray": [{},{},{}],
"cObjectArray": [{"a":"b", "x":1, "y":1.3}]}
{"timestamp": "2023-01-01T00:00:00", "str":"", "long":2,
"bool": false, "variant": "b", "variantEmptyObj":"b",
"variantEmtpyArray":2, "obj":{"a": 200, "b": {"x": "b", "y": 1.1, "z": [2, 4,
6]}}, "complexObj":{"x": 10, "y": [{"l": ["b", "b", "c"], "m": "b",
"n": 2}, [1, 2, 3]], "z": {"a": [5.5], "b":
false}}, "arrayString": ["a", "b", "c"], "arrayStringNulls":
[null, "b"], "arrayLong":[2, 3],
"arrayDouble":[3.3, 4.4, 5.5], "arrayDoubleNulls":[999, null, 5.5],
"arrayVariant":[null, null, 2.2], "arrayBool":[true, true],
"arrayNestedLong":[null, [null], []], "arrayObject":[{"x":
3},{"x":4}], "null": null, "cstr": "hello", "clong": 1234, "cdouble":
1.234, "cObj":{"x": 1, "y": "hello", "z": {"a": 1.1, "b": 1234, "c": ["a", "b",
"c"]}}, "cstringArray": ["a", "b", "c"], "cLongArray": [1, 2, 3],
"cDoubleArray": [1.1, 2.2, 3.3], "cEmptyArray":[]
, "cEmptyObj":{}, "cNullArray": [null, null], "cEmptyObjectArray": [{},{},{}],
"cObjectArray": [{"a":"b", "x":1, "y":1.3}]}
{"timestamp": "2023-01-01T00:00:00", "str":"null", "long":3, "double":2.0,
"variant": 3.0, "variantEmptyObj":3.3,
"variantEmtpyArray":3, "obj":{"a": 300},
"complexObj":{"x": 4, "y": [{"l": [], "m": 100, "n": 3},{"l":
["a"]}, {"l": ["b"], "n": []}], "z": {"a": [], "b": true}},
"arrayString": ["b", "c"], "arrayStringNulls": ["d", null,
"b"], "arrayLong":[1, 2, 3, 4], "arrayLongNulls":[1, 2, 3],
"arrayDouble":[1.1, 3.3], "arrayDoubleNulls":[null, 2.2, null],
"arrayVariant":[1, null, 1], "arrayBool":[true, null, true],
"arrayNestedLong":[[1], null, [1, 2, 3]], "arrayObject":[null,{"x":2}],
"cstr": "hello", "clong": 1234, "cdouble": 1.234,
"cObj":{"x": 1, "y": "hello", "z": {"a": 1.1, "b": 1234, "c": ["a", "b",
"c"]}}, "cstringArray": ["a", "b", "c"], "cLongArray": [1, 2, 3],
"cDoubleArray": [1.1, 2.2, 3.3], "cEmptyArray":[]
, "cEmptyObj":{}, "cNullArray": [null, null], "cEmptyObjectArray": [{},{},{}],
"cObjectArray": [{"a":"b", "x":1, "y":1.3}]}
-{"timestamp": "2023-01-01T00:00:00", "str":"b", "long":4, "double":3.3,
"bool": true, "variant": "4", "variantEmptyObj":{},
"variantEmtpyArray":4, "obj":{"a": 400, "b": {"x": "d", "y": 1.1, "z": [3,
4]}}, "complexObj":{"x": 1234,
"z": {"a": [1.1, 2.2, 3.3],
"b": true}}, "arrayString": ["d", "e"], "arrayStringNulls": ["b",
"b"], "arrayLong":[1, 4], "arrayLongNulls":[1],
"arrayDouble":[2.2, 3.3, 4.0],
"arrayVariant":["a", "b", "c"], "arrayBool":[null, false, true],
"arrayNestedLong":[[1, 2], [3, 4], [5, 6, 7]], "arrayObject":[{"x":
null},{"x":2}], "null": null, "cstr": "hello", "clong": 1234, "cdouble":
1.234, "cObj":{"x": 1, "y": "hello", "z": {"a": 1.1, "b": 1234, "c": ["a", "b",
"c"]}}, "cstringArray": ["a", "b", "c"], "cLongArray": [1, 2, 3],
"cDoubleArray": [1.1, 2.2, 3.3], "cEmptyArray":[]
, "cEmptyObj":{}, "cNullArray": [null, null], "cEmptyObjectArray": [{},{},{}],
"cObjectArray": [{"a":"b", "x":1, "y":1.3}]}
+{"timestamp": "2023-01-01T00:00:00", "str":"b", "long":4, "double":3.3,
"bool": true, "variant": "1", "variantEmptyObj":{},
"variantEmtpyArray":4, "obj":{"a": 400, "b": {"x": "d", "y": 1.1, "z": [3,
4]}}, "complexObj":{"x": 1234,
"z": {"a": [1.1, 2.2, 3.3],
"b": true}}, "arrayString": ["d", "e"], "arrayStringNulls": ["b",
"b"], "arrayLong":[1, 4], "arrayLongNulls":[1],
"arrayDouble":[2.2, 3.3, 4.0],
"arrayVariant":["a", "b", "c"], "arrayBool":[null, false, true],
"arrayNestedLong":[[1, 2], [3, 4], [5, 6, 7]], "arrayObject":[{"x":
null},{"x":2}], "null": null, "cstr": "hello", "clong": 1234, "cdouble":
1.234, "cObj":{"x": 1, "y": "hello", "z": {"a": 1.1, "b": 1234, "c": ["a", "b",
"c"]}}, "cstringArray": ["a", "b", "c"], "cLongArray": [1, 2, 3],
"cDoubleArray": [1.1, 2.2, 3.3], "cEmptyArray":[]
, "cEmptyObj":{}, "cNullArray": [null, null], "cEmptyObjectArray": [{},{},{}],
"cObjectArray": [{"a":"b", "x":1, "y":1.3}]}
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
