clintropolis commented on code in PR #14542:
URL: https://github.com/apache/druid/pull/14542#discussion_r1264028263


##########
processing/src/main/java/org/apache/druid/segment/nested/VariantColumnAndIndexSupplier.java:
##########
@@ -273,8 +304,99 @@ public <T> T as(Class<T> clazz)
     if (clazz.equals(NullValueIndex.class)) {
       final BitmapColumnIndex nullIndex = new 
SimpleImmutableBitmapIndex(nullValueBitmap);
       return (T) (NullValueIndex) () -> nullIndex;
+    } else if (clazz.equals(TypedValueIndex.class) && variantTypeSetByte == 
null && logicalType.isArray()) {
+      return (T) new ArrayValueIndex();
     }
     // coming soon...

Review Comment:
   oh, i guess i can remove this, there are a bunch of indexes that still need 
implemented



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to