abhishekrb19 commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1274223888
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -78,6 +84,9 @@ public KillUnusedSegmentsTask(
context
);
this.markAsUnused = markAsUnused != null && markAsUnused;
+ Preconditions.checkArgument(maxSegmentsToKill > 0, "maxSegmentsToKill must
be > 0");
Review Comment:
I think we can `throw InvalidInput.exception()` since this should be
user-facing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
