clintropolis commented on code in PR #14654:
URL: https://github.com/apache/druid/pull/14654#discussion_r1275383033
##########
processing/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -644,6 +644,37 @@ public static Number computeNumber(@Nullable String value)
return rv;
}
+ /**
+ * Cast an {@link ExprEval} to some {@link ExpressionType} that the value
will be compared with. If the value is not
+ * appropriate to use for comparison after casting, this method returns
null. For example, the
+ * {@link ExpressionType#DOUBLE} value 1.1 when cast to {@link
ExpressionType#LONG} becomes 1L, which is no longer
+ * appropriate to use for equality or range comparisons, while 1.0 is valid.
Review Comment:
oops, i forgot to update the javadoc since range doesn't use this anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
