gianm commented on code in PR #14654:
URL: https://github.com/apache/druid/pull/14654#discussion_r1274200450
##########
processing/src/main/java/org/apache/druid/math/expr/ExprEval.java:
##########
@@ -644,6 +644,27 @@ public static Number computeNumber(@Nullable String value)
return rv;
}
+ /**
+ * Returns true if an {@link ExprEval} which has been cast to some other
type is not equal to the original type.
+ * Effectively, this only happens with casts to {@link ExpressionType#LONG}
and {@link ExpressionType#LONG_ARRAY}.
Review Comment:
I do think it makes sense to put "equality" in the name. Rationale: for the
examples you mentioned, like comparing double `1.1` using match type long, the
logic needs to change if it's a range filter vs an equality filter. (`1.1` can
never be equal to a long, but it can be greater than or less than one)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
