clintropolis commented on code in PR #14654:
URL: https://github.com/apache/druid/pull/14654#discussion_r1275386050
##########
processing/src/main/java/org/apache/druid/query/filter/RangeFilter.java:
##########
@@ -514,10 +514,12 @@ private Supplier<DruidLongPredicate>
makeLongPredicateSupplier()
if (hasLowerBound()) {
ExprEval<?> lowerCast = lowerEval.castTo(ExpressionType.LONG);
if (lowerCast.isNumericNull()) {
+ // lower value is not null, but isn't convertible to a long, so is
effectively null, we treat this as not
+ // having a lower bound to be consistent with the bound filter, but
perhaps this is controversial...
Review Comment:
yeah, that seems reasonable to change to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
