clintropolis commented on code in PR #14654:
URL: https://github.com/apache/druid/pull/14654#discussion_r1275399107
##########
processing/src/main/java/org/apache/druid/query/filter/RangeFilter.java:
##########
@@ -812,6 +826,25 @@ public String toString()
}
}
+ /**
+ * if casting to a LONG typed ARRAY, first cast to a DOUBLE typed ARRAY and
then {@link Math#ceil(double)} on the
+ * values to ensure a correct lower bound
+ */
+ private static Object[] castArrayToCeil(ExprEval<?> lowerEval,
ExpressionType inputType)
+ {
+ if (ExpressionType.LONG_ARRAY.equals(inputType)) {
+ final ExprEval<?> doubleArray =
lowerEval.castTo(ExpressionType.DOUBLE_ARRAY);
Review Comment:
i believe that is effectively what will happen, expression casting to
numbers uses
https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/math/expr/ExprEval.java#L625
which does that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
