zachjsh commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1277972569
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -128,6 +146,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
}
// Kill segments
+ unusedSegments = maxSegmentsToKill == null
+ ? unusedSegments
Review Comment:
Thanks for your input @gianm . This makes sense to me. I guess kill tasks
will have another config property added, like `segmentIds` , and if that is
set, the killTask will ignore the other config properties like `interval` and
`datasource` ?
I guess one down side of this is that is makes the killTask harder to use by
end users, as they now will need to know the ids of segments that they want to
kill, if they want to do so manually. But I guess we will have the delete by
interval fallback that exists now, if the user still wished to delete segments
that way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
