zachjsh commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1277972569
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -128,6 +146,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
}
// Kill segments
+ unusedSegments = maxSegmentsToKill == null
+ ? unusedSegments
Review Comment:
Thanks for your input @gianm . This makes sense to me. I guess kill tasks
will have another config property added, like `segmentIds` , and if that is
set, the killTask will ignore the other config properties like `interval` and
`datasource` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
