zachjsh commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1279731790
##########
server/src/main/java/org/apache/druid/metadata/SqlSegmentsMetadataQuery.java:
##########
@@ -297,6 +315,66 @@ private CloseableIterator<DataSegment> retrieveSegments(
);
}
+ private CloseableIterator<DataSegment> retrieveSegments(
+ final String dataSource,
+ final List<String> segmentIds,
+ final boolean used
+ )
+ {
+ if (CollectionUtils.isNullOrEmpty(segmentIds)) {
+ return
CloseableIterators.withEmptyBaggage(ImmutableList.<DataSegment>of().iterator());
+ }
+ int batchSize = 100;
Review Comment:
maybe this batchSize should be pushed to higher level, and configurable,
Maybe the retreiveUnusedSegmentsIdAction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
