LakshSingla opened a new pull request, #14808:
URL: https://github.com/apache/druid/pull/14808
### Description
This PR adds the ability to configure the `maxSubqueryBytes` parameter with
a the following configurations:
1. `unlimited`: Same as unbounded, and defers to the original behavior.
2. `auto` : Instead of manually setting the maxSubqueryBytes, the user can
set it to apportion a fixed memory of the heap (which is calculated
automatically) for materializing the results of the subqueries for incoming
queries. This should cover most of the cases and allow the user to experiment
with the new feature with minimum friction.
3. Some specific numerical value: (Was present originally) - Reserve the
provided portion of bytes per query for materializing the subquery results.
This can be used for fine-tuning if the query patterns are known. For example,
if the operator knows that the cluster has only a couple of concurrent
subqueries, then they can configure it to a larger value than set by `auto`.
#### Release note
To be added
<hr>
##### Key changed/added classes in this PR
* `SubqueryLimitUtils`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
