LakshSingla commented on code in PR #14808:
URL: https://github.com/apache/druid/pull/14808#discussion_r1306937738
##########
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java:
##########
@@ -127,6 +137,12 @@ public ClientQuerySegmentWalker(
this.serverConfig = serverConfig;
this.cache = cache;
this.cacheConfig = cacheConfig;
+ this.subqueryLimitUtils = new SubqueryLimitUtils(
Review Comment:
I made the `SubqueryLimitUtils` class non-static since we compute the size
of the lookup at the start, and therefore it's required to have an internal
state. Perhaps renaming it to `SubqueryLimitHelper` would be more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
