LakshSingla commented on code in PR #14808:
URL: https://github.com/apache/druid/pull/14808#discussion_r1306895775
##########
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java:
##########
@@ -175,10 +197,13 @@ public <T> QueryRunner<T>
getQueryRunnerForIntervals(Query<T> query, Iterable<In
final DataSource freeTradeDataSource =
globalizeIfPossible(newQuery.getDataSource());
// do an inlining dry run to see if any inlining is necessary, without
actually running the queries.
final int maxSubqueryRows =
query.context().getMaxSubqueryRows(serverConfig.getMaxSubqueryRows());
- final long maxSubqueryMemory =
query.context().getMaxSubqueryMemoryBytes(serverConfig.getMaxSubqueryBytes());
+ final String maxSubqueryMemoryString = query.context()
+
.getMaxSubqueryMemoryBytes(serverConfig.getMaxSubqueryBytes());
+ final long maxSubqueryMemory =
subqueryLimitUtils.convertSubqueryLimitStringToLong(maxSubqueryMemoryString);
Review Comment:
Leaving this as is since merging the lines is causing the resulting
declaration to be super long, and is slightly confusing to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
