suneet-s commented on code in PR #14831:
URL: https://github.com/apache/druid/pull/14831#discussion_r1296235441
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java:
##########
@@ -43,9 +45,16 @@ public abstract class DruidCoordinatorConfig
@Default("PT1H")
public abstract Duration getCoordinatorMetadataStoreManagementPeriod();
+ @Config("druid.coordinator.kill.on")
+ @Default("false")
+ public abstract Boolean getAutoKillEnabled();
+
+ @Nullable
@Config("druid.coordinator.kill.period")
- @Default("P1D")
- public abstract Duration getCoordinatorKillPeriod();
+ public Duration getCoordinatorKillPeriod()
+ {
+ return null;
Review Comment:
Given that maxKillTasks is currently infinite - I think this should remain
P1D.
In another change, we can change the defaults so that it runs more
frequently, but also with better guardrails to prevent eating up all the
cluster capacity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
