zachjsh commented on code in PR #14831:
URL: https://github.com/apache/druid/pull/14831#discussion_r1296269962
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java:
##########
@@ -43,9 +45,16 @@ public abstract class DruidCoordinatorConfig
@Default("PT1H")
public abstract Duration getCoordinatorMetadataStoreManagementPeriod();
+ @Config("druid.coordinator.kill.on")
+ @Default("false")
+ public abstract Boolean getAutoKillEnabled();
+
+ @Nullable
Review Comment:
why remove this? Without this, being null, we will check the kill period
againt the indexer period. Or are you suggesting to remove that check?
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java:
##########
@@ -43,9 +45,16 @@ public abstract class DruidCoordinatorConfig
@Default("PT1H")
public abstract Duration getCoordinatorMetadataStoreManagementPeriod();
+ @Config("druid.coordinator.kill.on")
+ @Default("false")
+ public abstract Boolean getAutoKillEnabled();
+
+ @Nullable
Review Comment:
why remove this? Without this, being able to be null, we will check the kill
period againt the indexer period. Or are you suggesting to remove that check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
