zachjsh commented on code in PR #14831:
URL: https://github.com/apache/druid/pull/14831#discussion_r1296268046
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/KillUnusedSegments.java:
##########
@@ -63,25 +67,32 @@ public class KillUnusedSegments implements CoordinatorDuty
&& (KILL_TASK_TYPE.equals(status.getType()) &&
status.getId().startsWith(TASK_ID_PREFIX));
private static final Logger log = new Logger(KillUnusedSegments.class);
- private final long period;
+ @Nullable private final Long period;
private final long retainDuration;
private final boolean ignoreRetainDuration;
private final int maxSegmentsToKill;
+
+ /**
+ * Used to keep track of the last interval end time that was killed for each
+ * datasource.
+ */
+ private final Map<String, DateTime> datasourceToLastKillIntervalEnd;
Review Comment:
testing revealed that 1. is what happens, so thought it was no the end of
the world that we still have potential of submitting duplicate tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
