xvrl commented on code in PR #14827: URL: https://github.com/apache/druid/pull/14827#discussion_r1300443463
########## server/src/main/java/org/apache/druid/client/cache/MemcachedCacheConfig.java: ########## @@ -63,6 +63,12 @@ public class MemcachedCacheConfig @JsonProperty private String locator = "consistent"; + @JsonProperty + private boolean sslconnection = false; Review Comment: `TLS` is the more correct name for this feature, see https://github.com/memcached/memcached/wiki/TLS and https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-java#configuring-the-client-in-tls-mode I would suggest using `enableTls` for this config, which also aligns better with other Druid configs (e.g. https://druid.apache.org/docs/latest/operations/tls-support/#general-configuration) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
