xvrl opened a new pull request, #15106:
URL: https://github.com/apache/druid/pull/15106
Fix unsafe usage of maven dependency caching in `actions/setup-java`,
and replace with explicit save/restore of maven dependencies only without
relying on `mvn install`.
Using the the setup-java maven cache is not safe for steps calling `mvn
install`,
since setup-java cache keys are only based on the pom hashfiles whereas
mvn install causes artifacts specific to that commit to end up into the
local maven repository.
This disables the use of the setup-java maven cache for all steps calling
`mvn install`,
including: intellij-inspections and static-checks.
This also removes references to the setup-java cache keys, which we were
referencing as fall-back
cache using `restore-keys:` in some integration and unit tests.
Instead, to avoid pulling dependencies all the time, maven dependencies are
first resolved explicitly
using `maven dependencies:resolve`, and then cached/restored explicitly or
used as fallback for
cache misses with explicit commit tags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
