kgyrtkirk commented on code in PR #15106:
URL: https://github.com/apache/druid/pull/15106#discussion_r1363597660


##########
.github/workflows/static-checks.yml:
##########
@@ -51,7 +51,16 @@ jobs:
         with:
           distribution: 'zulu'
           java-version: ${{ matrix.java }}
-          cache: 'maven'
+
+      - name: cache maven dependencies
+        run: ${MVN} dependency:resolve dependency:resolve-plugins

Review Comment:
   calling `dependency:resolve` will not pull down all artifacts - especially 
that `node` related stuff which causes issues all the time.
   I think instead we should change `install` to `package` so that `mvn` 
doesn't pollute the local `.m2` caches - or that doesn't work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to