kgyrtkirk commented on code in PR #15106:
URL: https://github.com/apache/druid/pull/15106#discussion_r1356980635
##########
.github/workflows/unit-and-integration-tests-unified.yml:
##########
@@ -77,7 +77,11 @@ jobs:
with:
path: ~/.m2/repository
key: maven-${{ runner.os }}-${{ matrix.jdk }}-${{ github.sha }}
- restore-keys: setup-java-Linux-maven-${{ hashFiles('**/pom.xml') }}
+ # fallback cache entries to restore from. 'depsonly' keys are safe to
+ # restore since they don't contain any artifacts created by mvn
install
+ restore-keys: |
+ maven-${{ runner.os }}-depsonly-${{ hashFiles('**/pom.xml') }}
+ maven-${{ runner.os }}-depsonly-
Review Comment:
I wonder what saves the `maven-${{ runner.os }}-depsonly-` cache ; or caches
are served in a prefix manner?
I think that's not true; but I believe it looks up the cache around
https://github.com/actions/cache/blob/main/dist/restore/index.js line 45924
##########
.github/workflows/static-checks.yml:
##########
@@ -124,7 +133,15 @@ jobs:
with:
distribution: 'zulu'
java-version: '8'
- cache: 'maven'
+
+ # restore maven dependencies only. 'depsonly' keys are safe to restore
Review Comment:
yes - this will restore it ; but never save it - is that intentional?
##########
.github/workflows/static-checks.yml:
##########
@@ -51,7 +51,16 @@ jobs:
with:
distribution: 'zulu'
java-version: ${{ matrix.java }}
- cache: 'maven'
+
+ - name: cache maven dependencies
+ run: ${MVN} dependency:resolve dependency:resolve-plugins
Review Comment:
could you add `-B` or `-q` to get rid of download progress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
