soumyava commented on code in PR #15222:
URL: https://github.com/apache/druid/pull/15222#discussion_r1367368051
##########
processing/src/main/java/org/apache/druid/segment/join/PostJoinCursor.java:
##########
@@ -99,15 +108,15 @@ public Filter getPostJoinFilter()
@Override
public void advance()
{
- advanceUninterruptibly();
- BaseQuery.checkInterrupted();
+ baseCursor.advance();
Review Comment:
Will be good to put some comments as in why this change is being done in the
code for a future developer to follow.
##########
processing/src/main/java/org/apache/druid/segment/join/PostJoinCursor.java:
##########
@@ -99,15 +108,15 @@ public Filter getPostJoinFilter()
@Override
public void advance()
{
- advanceUninterruptibly();
- BaseQuery.checkInterrupted();
Review Comment:
Can we add a note on why the checkInterrupted() is not needed anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
