github-advanced-security[bot] commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1374640533


##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaDataSourceMetadata.java:
##########
@@ -26,9 +26,11 @@
 import 
org.apache.druid.indexing.seekablestream.SeekableStreamDataSourceMetadata;
 import 
org.apache.druid.indexing.seekablestream.SeekableStreamEndSequenceNumbers;
 import org.apache.druid.indexing.seekablestream.SeekableStreamSequenceNumbers;
+import org.apache.druid.java.util.common.IAE;
 
-public class KafkaDataSourceMetadata extends 
SeekableStreamDataSourceMetadata<KafkaTopicPartition, Long>
-{
+import java.util.Comparator;
+
+public class KafkaDataSourceMetadata extends 
SeekableStreamDataSourceMetadata<KafkaTopicPartition, Long> implements 
Comparable<KafkaDataSourceMetadata> {

Review Comment:
   ## Inconsistent compareTo
   
   This class declares [compareTo](1) but inherits equals; the two could be 
inconsistent.
   
   [Show more 
details](https://github.com/apache/druid/security/code-scanning/5937)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to