abhishekagarwal87 commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1363475906
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaDataSourceMetadata.java:
##########
@@ -58,4 +59,19 @@ protected
SeekableStreamDataSourceMetadata<KafkaTopicPartition, Long> createConc
{
return new KafkaDataSourceMetadata(seekableStreamSequenceNumbers);
}
+
+ @Override
+ public int compareTo(DataSourceMetadata other)
+ {
+ if (!getClass().equals(other.getClass())) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+ final SeekableStreamDataSourceMetadata<KafkaTopicPartition, Long> that =
(SeekableStreamDataSourceMetadata<KafkaTopicPartition, Long>) other;
+
+ return
getSeekableStreamSequenceNumbers().compareTo(that.getSeekableStreamSequenceNumbers());
Review Comment:
```suggestion
return
getSeekableStreamSequenceNumbers().compareTo(that.getSeekableStreamSequenceNumbers(),
LongComparator());
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java:
##########
@@ -147,6 +148,37 @@ public SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> plus(
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other)
Review Comment:
```suggestion
public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other, Comparator<SequenceOffsetType> comparator)
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamEndSequenceNumbers.java:
##########
@@ -147,6 +148,37 @@ public SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> plus(
}
}
+ @Override
+ public int compareTo(SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> other)
+ {
+ if (this.getClass() != other.getClass()) {
+ throw new IAE(
+ "Expected instance of %s, got %s",
+ this.getClass().getName(),
+ other.getClass().getName()
+ );
+ }
+
+ final SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType> otherStart =
+ (SeekableStreamEndSequenceNumbers<PartitionIdType,
SequenceOffsetType>) other;
+
+ if (stream.equals(otherStart.stream)) {
+ //Same stream, compare the offset
+ AtomicReference<Boolean> res = new AtomicReference<>(false);
+ partitionSequenceNumberMap.forEach(
+ (partitionId, sequenceOffset) -> {
+ if (otherStart.partitionSequenceNumberMap.get(partitionId) != null
&& (Long) sequenceOffset > (Long)
otherStart.partitionSequenceNumberMap.get(partitionId)) {
Review Comment:
```suggestion
if (otherStart.partitionSequenceNumberMap.get(partitionId) !=
null && comparator.compare(sequenceOffset,
otherStart.partitionSequenceNumberMap.get(partitionId) ) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
