georgew5656 opened a new pull request, #15311: URL: https://github.com/apache/druid/pull/15311
Fixes a couple bugs with some of the AbstractTask.run implementation that was added to support mmless ingestion.. ### Description If a task in mmless ingestion fails during setup(), then cleanup is called with taskStatus=TaskStatus.running(getId()) because of a error in the logic. This can cause issues because then the overlord will think the task is running when in reality it has exited. Separately, as a part of https://github.com/apache/druid/commit/dc0b163e192545c802b7fe2b3271e035cc1e70ff, mmless ingestion will normally report the status to the overlord in the UpdateStatusAction api call, with the deep storage status.json being just a backup option. When this status is reported, the error message is dropped because UpdateStateAction only takes in a string instead of a TaskStatus object. To fix this, I added a TaskStatus field to the UpdateStatusAction (i left the string value in for backwards compatibility). #### Release note Fix some error reporting with mmless ingestion ##### Key changed/added classes in this PR * `AbstractTask` * `UpdateStatusAction` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [X] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [X] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
