georgew5656 commented on code in PR #15311:
URL: https://github.com/apache/druid/pull/15311#discussion_r1381761201
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java:
##########
@@ -196,11 +197,11 @@ public void cleanUp(TaskToolbox toolbox, TaskStatus
taskStatus) throws Exception
return;
}
+ TaskStatus taskStatusToReport = taskStatus == null
+ ? TaskStatus.failure(id, "Task failed to run")
+ : taskStatus;
// report back to the overlord
- UpdateStatusAction status = new UpdateStatusAction("successful");
- if (taskStatus.isFailure()) {
- status = new UpdateStatusAction("failure");
- }
+ UpdateStatusAction status = new UpdateStatusAction("", taskStatusToReport);
Review Comment:
just to avoid a nullpointer error on the comparison to successful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
