YongGang commented on code in PR #15311: URL: https://github.com/apache/druid/pull/15311#discussion_r1380736854
########## indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java: ########## @@ -186,7 +187,7 @@ public final TaskStatus run(TaskToolbox taskToolbox) throws Exception public abstract TaskStatus runTask(TaskToolbox taskToolbox) throws Exception; @Override - public void cleanUp(TaskToolbox toolbox, TaskStatus taskStatus) throws Exception + public void cleanUp(TaskToolbox toolbox, @Nullable TaskStatus taskStatus) throws Exception Review Comment: Although no harm to annotate nullable here, I think taskStatus won't be possible null as it will be set to a value in all the code path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
