suneet-s commented on code in PR #15311:
URL: https://github.com/apache/druid/pull/15311#discussion_r1381912508
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/UpdateStatusAction.java:
##########
@@ -34,13 +34,24 @@ public class UpdateStatusAction implements TaskAction<Void>
{
@JsonIgnore
private final String status;
+ @JsonIgnore
+ private final TaskStatus statusFull;
+
+ public UpdateStatusAction(
+ String status
+ )
+ {
+ this(status, null);
+ }
@JsonCreator
public UpdateStatusAction(
- @JsonProperty("status") String status
+ @JsonProperty("status") String status,
+ @JsonProperty("statusFull") TaskStatus statusFull
)
{
this.status = status;
+ this.statusFull = statusFull;
Review Comment:
That's fine.
My thinking was that in the perform method either status or statusFull is
used. So if a caller calls this method with both set, it's likely a mistake,
and they won't know about it unless they closely inspect the results of the
perform method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
