kgyrtkirk commented on code in PR #15465:
URL: https://github.com/apache/druid/pull/15465#discussion_r1456410693


##########
server/src/test/java/org/apache/druid/server/QueryStackTests.java:
##########
@@ -385,4 +374,22 @@ public static JoinableFactory 
makeJoinableFactoryFromDefault(
 
     return new MapJoinableFactory(setBuilder.build(), mapBuilder.build());
   }
+
+  public static Injector injector()

Review Comment:
   they live right now in different modules (`sql` / `server`)  ; but I've 
tried to unify the common parts and in the process I've removed the 
`CalciteTestInjectorBuilder`  class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to