kgyrtkirk commented on code in PR #15465:
URL: https://github.com/apache/druid/pull/15465#discussion_r1455469576
##########
server/src/main/java/org/apache/druid/initialization/ServerInjectorBuilder.java:
##########
@@ -106,7 +106,7 @@ public Injector build()
CoreInjectorBuilder coreBuilder = new CoreInjectorBuilder(childInjector,
nodeRoles).forServer();
// Override with the per-service modules.
- ServiceInjectorBuilder serviceBuilder = new
ServiceInjectorBuilder(coreBuilder).addAll(
+ ServiceInjectorBuilder serviceBuilder = (ServiceInjectorBuilder) new
ServiceInjectorBuilder(coreBuilder).addAll(
Review Comment:
unfortunately its needed because:
* [`ServiceInjectorBuilder extends
DruidInjectorBuilder`](https://github.com/apache/druid/blob/c27f5bf52f6690e76e39381f57683b374787b222/server/src/main/java/org/apache/druid/initialization/ServiceInjectorBuilder.java#L33)
* `addAll` is defined in `DruidInjectorBuilder` to [return
`DruidInjectorBuilder`](https://github.com/apache/druid/blob/c27f5bf52f6690e76e39381f57683b374787b222/server/src/main/java/org/apache/druid/guice/DruidInjectorBuilder.java#L120C28-L120C28);
but returns `this` ; which due to extends will be a `ServiceInjectorBuilder`
* the constructor of `ExtensionInjectorBuilder` wants a
`ServiceInjectorBuilder`
this can be fixed - but I didn't wanted to do it in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
