kgyrtkirk commented on code in PR #15465:
URL: https://github.com/apache/druid/pull/15465#discussion_r1455554822
##########
sql/src/test/java/org/apache/druid/sql/calcite/SqlTestFrameworkConfig.java:
##########
@@ -103,24 +106,63 @@ public SqlTestFrameworkConfig defaultConfig()
public Statement apply(Statement base, Description description)
{
config = description.getAnnotation(SqlTestFrameworkConfig.class);
+ if (config == null) {
+ config =
description.getTestClass().getAnnotation(SqlTestFrameworkConfig.class);
Review Comment:
there was a testclass using it
```
@SqlTestFrameworkConfig(resultCache = ResultCacheMode.ENABLED)
public class CalciteQueryWithResultCacheTest extends CalciteQueryTest
{
}
```
however I was not able to make it pass correctly....and I've to add a
`@Ignore`.
to reduce the volume of this change - I've removed that testclass; and all
the related fixes - as I'm not anymore sure how much of those issues were real
or somehow misbehaviours caused by the test system itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
