kgyrtkirk commented on code in PR #15465:
URL: https://github.com/apache/druid/pull/15465#discussion_r1455477504
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -550,16 +569,17 @@ public QueryLifecycleFactory queryLifecycleFactory(final
Injector injector)
private final AuthorizerMapper authorizerMapper =
CalciteTests.TEST_AUTHORIZER_MAPPER;
private final SqlEngine engine;
- private SqlTestFramework(Builder builder)
+ private SqlTestFramework(Builder builder) throws Exception
{
this.builder = builder;
this.componentSupplier = builder.componentSupplier;
+ builder.componentSupplier.beforeNewFrameworkCreateHook();
Properties properties = new Properties();
this.componentSupplier.gatherProperties(properties);
Injector startupInjector = new StartupInjectorBuilder()
.withProperties(properties)
.build();
- DruidInjectorBuilder injectorBuilder = new
CoreInjectorBuilder(startupInjector)
+ CoreInjectorBuilder injectorBuilder = (CoreInjectorBuilder) new
CoreInjectorBuilder(startupInjector)
Review Comment:
`ignoreLoadScopes` and `addModule` returns `DruidInjectorBuilder` ;
the cast was needed more-or-less because `ServiceInjector` wants a
`CoreInjectorBuilder`
I'll submit a separate PR to fix the builders
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
