LakshSingla commented on code in PR #15559:
URL: https://github.com/apache/druid/pull/15559#discussion_r1494039215
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -301,6 +298,9 @@ public static String convertObjectToString(@Nullable Object
valObj)
{
if (valObj == null) {
return null;
+ } else if (valObj instanceof Object[]) {
+ // TODO(laksh): Get this change vetted
+ return Arrays.toString((Object[]) valObj);
Review Comment:
It happened in one of the funny cases that you alluded to before, where we
try to compare arrays as strings. Since I wasn't able to find the test case
directly, I have pushed a change without this method to see where it fails.
Before the patch, when we used `ComparableStringArrays` and `ComparableList,`
the `toString` was implicitly returning the required representation, however
with the change, it started returning `Object@...`, which doesn't sit well with
the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
