clintropolis commented on code in PR #15559:
URL: https://github.com/apache/druid/pull/15559#discussion_r1500534419
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/DictionaryBuilding.java:
##########
@@ -53,6 +63,39 @@ public static <T> Object2IntMap<T> createReverseDictionary()
return m;
}
+ private static <T> Object2IntMap<T> createReverseDictionary(final
Hash.Strategy<T> hashStrategy)
+ {
+ final Object2IntOpenCustomHashMap<T> m = new
Object2IntOpenCustomHashMap<>(hashStrategy);
Review Comment:
i think this is fine for now, but i wonder if it is worth
exploring/measuring using a sorted set instead like avl or rb set. if the cost
difference isn't too dramatic we could instead just get by using the comparator
instead of needing equals and hashcode to be implemented, which seems like it
would simplify some things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
