LakshSingla commented on code in PR #15559:
URL: https://github.com/apache/druid/pull/15559#discussion_r1495029741
##########
processing/src/main/java/org/apache/druid/query/groupby/orderby/DefaultLimitSpec.java:
##########
@@ -437,19 +437,22 @@ private Ordering<ResultRow> dimensionOrdering(
{
Comparator arrayComparator = null;
if (columnType.isArray()) {
- final ValueType elementType = columnType.getElementType().getType();
+ final TypeSignature<ValueType> elementType = columnType.getElementType();
if (columnType.getElementType().isNumeric()) {
Review Comment:
Adding to this and the previous comment, it is also ambiguous to the person
writing the query, that the custom StringComparators coerce the entire array
before comparing, or if it compares the elements piecewise, with the custom
comparator (the latter happens).
I guess it should be fine to drop the support for "unnatural" comparators
for the non-string arrays entirely since that's the most obscure use case. I
wonder if we should discuss removing the custom comparators for the string
types, and the numeric types in the mailing list before committing to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
