clintropolis commented on code in PR #15559:
URL: https://github.com/apache/druid/pull/15559#discussion_r1500539030
##########
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java:
##########
@@ -301,6 +298,9 @@ public static String convertObjectToString(@Nullable Object
valObj)
{
if (valObj == null) {
return null;
+ } else if (valObj instanceof Object[]) {
+ // TODO(laksh): Get this change vetted
+ return Arrays.toString((Object[]) valObj);
Review Comment:
i feel like we could probably consider just make this an error case too,
maybe also worth a dev list thread along with dropping support for funny string
comparators on non-string types. i'll try to start a dev list thread soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
