AmatyaAvadhanula commented on code in PR #15952:
URL: https://github.com/apache/druid/pull/15952#discussion_r1508737014
##########
processing/src/main/java/org/apache/druid/timeline/partition/PartitionHolder.java:
##########
@@ -60,14 +67,24 @@ public PartitionHolder(List<PartitionChunk<T>>
initialChunks)
}
}
- protected PartitionHolder(OvershadowableManager<T> overshadowableManager)
+ protected PartitionHolder(OvershadowableManager<T> overshadowableManager,
short maxMinorVersion)
{
this.overshadowableManager = overshadowableManager;
+ this.maxMinorVersion = maxMinorVersion;
}
public boolean add(PartitionChunk<T> chunk)
{
- return overshadowableManager.addChunk(chunk);
+ boolean added = overshadowableManager.addChunk(chunk);
Review Comment:
If we do, we would have to maintain counts and complicate the logic.
This patch is intended to help large clusters without segment locking i.e
distinct minor versions.
Would it be better if a more elaborate solution which updates the state when
remove is called is implemented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
