AmatyaAvadhanula commented on code in PR #15952:
URL: https://github.com/apache/druid/pull/15952#discussion_r1531604207
##########
processing/src/main/java/org/apache/druid/timeline/partition/PartitionHolder.java:
##########
@@ -34,16 +34,26 @@ public class PartitionHolder<T extends Overshadowable<T>>
implements Iterable<Pa
{
private final OvershadowableManager<T> overshadowableManager;
+ // Maintains the maximum minor version across all the added segments.
Review Comment:
Done
##########
processing/src/main/java/org/apache/druid/timeline/VersionedIntervalTimeline.java:
##########
@@ -450,6 +450,18 @@ private Map<Interval, Map<VersionType, TimelineEntry>>
computeOvershadowedPartit
return overshadowedPartitionsTimeline;
}
+ /**
+ * 0) Determine the TimelineEntry with the given interval
+ * 1) If the major versions are equal, the segment is overshadowed iff any
of the segments in the TimelineEntry overshadows it.
+ * 2) If the major versions are different, simply return true if the
TimelineEntry has a greater major version. False otherwise.
+ * 3) If there is no TimelineEntry with the same interval, find one which
contains the input interval.
+ * 4) If a TimelineEntry is found in step 3, repeat steps 1, 2 with it.
Return false otherwise.
+ *
+ * @param interval The interval of the overshadowable object (segment)
+ * @param version The version of the overshadowable object (segment)
+ * @param object The overshadowable object to be determined as overshadowed
or not
+ * @return true iff the object is overshadowed in this timeline
+ */
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
