kfaraz commented on code in PR #15952:
URL: https://github.com/apache/druid/pull/15952#discussion_r1524318711
##########
processing/src/main/java/org/apache/druid/timeline/partition/PartitionHolder.java:
##########
@@ -33,17 +33,24 @@
public class PartitionHolder<T extends Overshadowable<T>> implements
Iterable<PartitionChunk<T>>
{
private final OvershadowableManager<T> overshadowableManager;
+ private short maxMinorVersion;
Review Comment:
Please address this comment so that we can merge this PR.
`maxMinorVersion` is not a concept I would want to expose outside of the
timeline class. Best to keep all the logic in one place alongwith relevant
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
