Akshat-Jain commented on PR #16358: URL: https://github.com/apache/druid/pull/16358#issuecomment-2097744888
@kfaraz @cryptoe Have made some changes in the latest commit https://github.com/apache/druid/pull/16358/commits/bb4a093311298e03aed3704f37fb3870dbbbc7fb. Summarizing them here: 1. Use mutable Set as the class variable in LookupLoadingSpec. `LookupLoadingSpec#getLookupsToLoad` still returns an immutable copy of the set of lookups. 2. Add `LookupLoadingSpec#addLookupToLoad` method to abstract away this logic from PlannerContext, and to avoid creating a new instance of LookupLoadingSpec everytime we have to add a new lookup for loading in PlannerContext. To achieve this, I had to make the fields non-final in LookupLoadingSpec. 3. Add `LookupLoadingSpec#createSpecFromMode` method to create a new/different instance of LookupLoadingSpec for every instance of PlannerContext. Previously it was defaulting to `LookupLoadingSpec.NONE`, which is incorrect as it points to the same instance of LookupLoadingSpec across different instances of PlannerContext. Hope this works? Appreciate your thoughts on these changes, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
