kfaraz commented on PR #16358: URL: https://github.com/apache/druid/pull/16358#issuecomment-2098208734
> Previously it was defaulting to LookupLoadingSpec.NONE, which is incorrect as it points to the same instance of LookupLoadingSpec across different instances of PlannerContext. Why is this a problem? There is no harm in pointing to the same instance if the instance is immutable. It was written this way on purpose. We don't need the method `LookupLoadingSpec.createSpecFromMode()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
